-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional logging to script calculate_instance_number.py
#16331
Merged
wangxin
merged 2 commits into
sonic-net:master
from
yutongzhang-microsoft:yutongzhang/add_debug_info
Jan 6, 2025
Merged
Add additional logging to script calculate_instance_number.py
#16331
wangxin
merged 2 commits into
sonic-net:master
from
yutongzhang-microsoft:yutongzhang/add_debug_info
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/add_debug_info
branch
from
January 3, 2025 07:01
f5339e2
to
18dde23
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/add_debug_info
branch
from
January 3, 2025 07:02
18dde23
to
21de820
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/add_debug_info
branch
from
January 3, 2025 07:04
21de820
to
b13194e
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
changed the title
Add debug info
Add info into script Jan 3, 2025
calculate_instance_number.py
yutongzhang-microsoft
changed the title
Add info into script
Add additional logging to script Jan 3, 2025
calculate_instance_number.py
calculate_instance_number.py
xwjiang-ms
reviewed
Jan 3, 2025
@@ -131,6 +134,8 @@ def main(scripts, topology, branch): | |||
parser.add_argument("--branch", help="Test branch", type=str, default="") | |||
args = parser.parse_args() | |||
|
|||
logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to add the basic config below the import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
xwjiang-ms
approved these changes
Jan 3, 2025
wangxin
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In this PR, we have added additional logging to the
calculate_instance_number.py
script to improve tracking and visibility of its operations.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In this PR, we have added additional logging to the calculate_instance_number.py script to improve tracking and visibility of its operations.
How did you do it?
Add additional logging to the
calculate_instance_number.py
script.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation