Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual] [PR:16206] fix: bump memory limit for Cisco 8000 supervisor #16320

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

cyw233
Copy link
Contributor

@cyw233 cyw233 commented Jan 3, 2025

Description of PR

Increase the memory threshold for the Cisco 8000 supervisor to 65% to make the test stable.

Summary:
Fixes # (issue) Microsoft ADO 30114189

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

During recent nightly runs, we observed that the Cisco 8000 supervisor had an average memory usage of 59.7% (calculated from the values 60.3, 59.9, 58.9, 59.2, 59.8, and 60.2). Since the memory threshold is set at 60%, this resulted in two failures. To ensure the stability of the tests, we propose increasing the memory threshold for the Cisco 8000 supervisor to 65%.

How did you do it?

How did you verify/test it?

I ran the updated code on Cisco 8000 and can confirm it's working well.

Any platform specific information?

Cisco 8000 chassis

Supported testbed topology if it's a new test case?

Documentation

During recent nightly runs, we observed that the Cisco 8000 supervisor had an average memory usage of 59.7% (calculated from the values 60.3, 59.9, 58.9, 59.2, 59.8, and 60.2). Since the memory threshold is set at 60%, this resulted in two failures. To ensure the stability of the tests, we propose increasing the memory threshold for the Cisco 8000 supervisor to 65%.
@cyw233 cyw233 requested a review from prgeor as a code owner January 3, 2025 02:08
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233
Copy link
Contributor Author

cyw233 commented Jan 3, 2025

Original PR: #16206

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 9899dea into sonic-net:202405 Jan 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants