Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes to test_intf_fec.py #16302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nhe-NV
Copy link
Contributor

@nhe-NV nhe-NV commented Jan 2, 2025

Description of PR

Add fixes to the test_intf_fec.py test.
Summary: This is refactor for #14908, could not update on the PR since don't have permission.
Fixes # (issue)

  1. Correct inequality direction in test_verify_fec_stats_counters
  2. Delete commans before using int() in test_verify_fec_stats_counters
  3. Add fixture to disable/enable BGP before/after test to allow faster fec configuration.
  4. Add retry mechanism to fec configuration to allow time for configuration to take place.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fix issues seen with the test.

How did you do it?

How did you verify/test it?

Any platform specific information?

Platforms with Optic cables might require longer time to configure fec.

Supported testbed topology if it's a new test case?

Documentation

@nhe-NV nhe-NV requested a review from prgeor as a code owner January 2, 2025 13:57
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Pull request contains merge conflicts.

1. Correct inequality direction in test_verify_fec_stats_counters
2. Delete commans before using int() in test_verify_fec_stats_counters
3. Add fixture to disable/enable BGP before/after test to allow faster fec configuration.
4. Add retry mechanism to fec configuration to allow time for configuration to take place.
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants