[action] [PR:15951] Adjust t2 timing in tests/platform_tests/test_reload_config.py #16284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onic-net#15951) Description of PR Summary: Fixes # (issue) 3045798 The decision was to enable this test gap in sonic-net#13476 however we mentioned that we need to increase the time. By default, the reboot time will be decided from constant variable reboot_ctrl_dict which will set the REBOOT_TYPE_COLD = 300 https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133 For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly. This PR will fix that Approach What is the motivation for this PR? How did you do it? Enable plt_reboot_ctrl_overwrite if platform is T2 Signed-off-by: Austin Pham <[email protected]>
|
/azp run |
8 tasks
|
Original PR: #15951 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue) 3045798
The decision was to enable this test gap in #13476 however we mentioned that we need to increase the time.
By default, the reboot time will be decided from constant variable
reboot_ctrl_dictwhich will set theREBOOT_TYPE_COLD= 300https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/reboot.py#L133
For T2, this time is not sufficient enough and lead to failure. We will adjust the time accordingly.
This PR will fix that
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Enable plt_reboot_ctrl_overwrite if platform is T2
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation