Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_idf_isolated_withdraw_all more robust #16271

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

ysmanman
Copy link
Contributor

@ysmanman ysmanman commented Dec 31, 2024

The test is flaky because it checks routes on neighbors immediately after isolating dut. So the test may fail if the neighbors (VM) are not able to process route withdraw in time. Make the test more robust by retrying validation for 60 seconds.

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • [ x] 202405

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

The test is flaky because it checks routes on neighbors immediately
after isolating dut. So the test may fail if the neighbors (VM) are
not able to process route withdraw in time. Make the test more robust
by retrying validation for 60 seconds.
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ysmanman
Copy link
Contributor Author

@arlakshm @kenneth-arista

@rlhui rlhui requested a review from tjchadaga January 3, 2025 05:07
@arlakshm arlakshm merged commit f020006 into sonic-net:master Jan 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants