Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:15997] Remove Cisco platform sku-sensors-data #16181

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:

Cisco platforms have migrated away from sensord/lm-sensors in favor of sensormond for better monitoring of sensors. sensor/lm-sensors has been disabled for Cisco platforms, so the sku-sensors-data configurations should be removed so test_sensors.py can pass.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Sensor configurations hard-coded into sku-sensors-data are actually dynamic from the OS, so test_sensors.py can start to fail due to varying changes that may change sensor device addresses and naming that are dynamically allocated by the OS. sensormond uses consistent configurations, and SONiC is able to react to alarms from sensors, where sensord/lm-sensors is unable.

How did you do it?

Remove Cisco platform sku-sensors-data configurations.

How did you verify/test it?

Run test_sensors.py

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

@mssonicbld
Copy link
Collaborator Author

/azp run

@mssonicbld
Copy link
Collaborator Author

Original PR: #15997

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit d1ec8bd into sonic-net:202405 Dec 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants