[action] [PR:15930] [Mellanox] Update telemetry event test cpu threshold #16149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-net#15930) - What is the motivation for this PR? telemetry.test_events#test_events failure due to gRPC error at sn4280, it has more cpu cores, so the cpu threshold should be lower. - How did you do it? Use lower cpu threshold for Nvidia platforms once it is clear that the new threshold is OK for all Nvidia platforms. - How did you verify/test it? Run it in internal regression
|
/azp run |
8 tasks
|
Original PR: #15930 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Use 1 percent as cpu threshold for all the platforms.
It covers the sn4280, it has more cpu cores, and the threshold should be lower than 2 percent.
Summary:
Fixes # (issue)
telemetry.test_events#test_events failure
Type of change
Back port request
Approach
What is the motivation for this PR?
telemetry.test_events#test_events failure due to gRPC error at sn4280, it has more cpu cores, so the cpu threshold should be lower.
How did you do it?
Use lower cpu threshold for Nvidia platforms once it is clear that the new threshold is OK for all Nvidia platforms.
How did you verify/test it?
Run it in internal regression
Any platform specific information?
run the test on multiple Nvidia platforms.
Supported testbed topology if it's a new test case?
Documentation