Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump BFD toggle wait timeout #15939

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cyw233
Copy link
Contributor

@cyw233 cyw233 commented Dec 7, 2024

Description of PR

Bump the BFD toggle wait timeout to 450 seconds to give BFD session enough time to go up/down.

Summary:
Fixes # (issue) Microsoft ADO 30112171

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

We noticed that 300 seconds is not enough for BFD session to go up/down, so Cisco suggested us to bump it to 450 seconds.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@yejianquan
Copy link
Collaborator

we have 2 Cisco chassis, one can stably pass with 300 limitation.
Another one can't, before we merge this change, let's verify it on the failed chassis to see whether increasing time out can help

@yejianquan yejianquan merged commit b5f8fe8 into sonic-net:master Dec 11, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 11, 2024
Description of PR
Bump the BFD toggle wait timeout to 450 seconds to give BFD session enough time to go up/down.

Summary:
Fixes # (issue) Microsoft ADO 30112171

Approach
What is the motivation for this PR?
We noticed that 300 seconds is not enough for BFD session to go up/down, so Cisco suggested us to bump it to 450 seconds.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15989

mssonicbld pushed a commit that referenced this pull request Dec 11, 2024
Description of PR
Bump the BFD toggle wait timeout to 450 seconds to give BFD session enough time to go up/down.

Summary:
Fixes # (issue) Microsoft ADO 30112171

Approach
What is the motivation for this PR?
We noticed that 300 seconds is not enough for BFD session to go up/down, so Cisco suggested us to bump it to 450 seconds.
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 3, 2025
Description of PR
Bump the BFD toggle wait timeout to 450 seconds to give BFD session enough time to go up/down.

Summary:
Fixes # (issue) Microsoft ADO 30112171

Approach
What is the motivation for this PR?
We noticed that 300 seconds is not enough for BFD session to go up/down, so Cisco suggested us to bump it to 450 seconds.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants