[dhcp_relay] Update error log for dhcp server route incorrect #15898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
tests/dhcp_relay/conftest.py:151
- The phrase "but not it's going through mgmt interface" should be corrected to "but instead it's going through mgmt interface".
"Packets relayed to DHCP server should go through default route via upstream neighbor, but not it's going through mgmt interface, which means device is in a unhealthy status"
yaqiangz
force-pushed
the
azure-master_dhcp_route
branch
from
f57d308 to
0cf6296
Compare
yaqiangz
force-pushed
the
azure-master_dhcp_route
branch
from
0cf6296 to
bf7e715
Compare
yaqiangz
force-pushed
the
azure-master_dhcp_route
branch
from
179b0da to
ff2fc5e
Compare
lizhijianrd
approved these changes
Dec 6, 2024
|
Hi @wangxin could you please help to merge this PR? |
wangxin
approved these changes
Dec 10, 2024
|
Hi @bingwang-ms could you please help to approve the backport request? |
|
Hi @yxieca could you please help to approve this backport request? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 11, 2024
…net#15898) Error log for default route incorrect is ambiguous
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 11, 2024
…net#15898) Error log for default route incorrect is ambiguous
|
Cherry-pick PR to 202405: #15995 |
|
Cherry-pick PR to 202311: #15996 |
This was referenced Dec 11, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Dec 11, 2024
Error log for default route incorrect is ambiguous
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Dec 13, 2024
Error log for default route incorrect is ambiguous
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 24, 2024
…net#15898) Error log for default route incorrect is ambiguous
|
Cherry-pick PR to 202411: #16215 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 24, 2024
Error log for default route incorrect is ambiguous
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Error log for default route incorrect is ambiguous
How did you do it?
Update the log
How did you verify/test it?
Run test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation