Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all port pfcwd storm test to make it more stable #15870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update all port pfcwd storm test to make it more stable #15870

wants to merge 1 commit into from

Conversation

echuawu
Copy link
Contributor

@echuawu echuawu commented Dec 4, 2024

Description of PR

Update all port pfcwd storm test to make it more stable

  1. Optimize background traffic
  2. Fix arp resolve issue
  3. Remove ptf leftovers added in pfcwd test

Change-Id: I5e0a5f4157bd0e22f5bc2f28df977bfccb679603

Summary:
Fixes # (issue)
All port pfcwd storm test not stable enough.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Update all port pfcwd storm test is not stable engough.

How did you do it?

Optimize background traffic and arp resolvation.

How did you verify/test it?

Run it in internal regression.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@liat-grozovik
Copy link
Collaborator

@yxieca @bingwang-ms could you please review or suggest someone to review?

@bingwang-ms
Copy link
Collaborator

@kperumalbfn Can you help review if you get a chance?

@yxieca yxieca requested a review from lipxu December 18, 2024 18:46
@yxieca
Copy link
Collaborator

yxieca commented Dec 18, 2024

@lipxu please help review.

@echuawu echuawu force-pushed the update_pfcwd_all_port_storm branch from 091eb73 to ec9237d Compare December 24, 2024 03:50
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

lipxu
lipxu approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@lipxu lipxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://elastictest.org/scheduler/testplan/67643e9eb7a7fea3d1f4ede2?leftSideViewMode=detail
Passed internal tests on Broadcom devices.

@echuawu echuawu force-pushed the update_pfcwd_all_port_storm branch from ec9237d to eefaf76 Compare December 24, 2024 11:13
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Dec 25, 2024

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu echuawu force-pushed the update_pfcwd_all_port_storm branch from eefaf76 to 304bb7c Compare December 25, 2024 06:11
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Jan 2, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Jan 3, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu echuawu force-pushed the update_pfcwd_all_port_storm branch from 304bb7c to 7e4a958 Compare January 3, 2025 02:24
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Jan 3, 2025

Hi @bingwang-ms , the 2 checker failure were due to testbed related issue, I had retriggered them many times, but still could not pass them. Do you know from whom could I get help?

1. DUTHOST_UNREACHABLE
2025-01-03T04:53:27.8357425Z Error type: DUTHOST_UNREACHABLE
2025-01-03T04:53:27.8358232Z Error message: DUT host unreachable for vms-kvm-dual-t0 on running test_pretest.py|||vms-kvm-dual-t0_377521
2025-01-03T04:53:27.8359427Z Operation failed with exception: Exception('Test plan id: 677764fe98ec838ee83d611c, status: FAILED, result: FAILED, Elapsed 602 seconds. Check https://elastictest.org/scheduler/testplan/677764fe98ec838ee83d611c for test plan status')

2. UPGRADE_IMAGE_FAILED
2025-01-03T04:43:14.9498342Z Error type: UPGRADE_IMAGE_FAILED
2025-01-03T04:43:14.9499389Z Error message: Prepare testbed failed: testbed_q_sonic-elastictest-prod-vmss-E8s-v3_261321 for UPGRADE_IMAGE_FAILED, testbed_id is: 67776755e396f7257aacb936, cmd is: Download image
2025-01-03T04:43:14.9500664Z Operation failed with exception: Exception('Test plan id: 677764fbb9fbfafb6a51c2e7, status: FAILED, result: FAILED, Elapsed 782 seconds. Check https://elastictest.org/scheduler/testplan/677764fbb9fbfafb6a51c2e7 for test plan status')

@bingwang-ms
Copy link
Collaborator

Hi @echuawu, can you sync code with master branch? The test failed at prepare testbed. Probably it has been fixed.

@echuawu echuawu force-pushed the update_pfcwd_all_port_storm branch from 7e4a958 to d036287 Compare January 6, 2025 02:51
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Jan 6, 2025

Hi @echuawu, can you sync code with master branch? The test failed at prepare testbed. Probably it has been fixed.

Thanks!

@echuawu echuawu force-pushed the update_pfcwd_all_port_storm branch from d036287 to fa81826 Compare January 8, 2025 03:01
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu echuawu mentioned this pull request Jan 10, 2025
Open
8 tasks
@bingwang-ms
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Update all port pfcwd storm test to make is more stable
7b59f3d 
1. Optimize background traffic
2. Optimize pfcwd polling interval
3. Fix arp resolve issue
4. Remove ptf leftovers added in pfcwd test

Change-Id: I5e0a5f4157bd0e22f5bc2f28df977bfccb679603
@echuawu echuawu force-pushed the update_pfcwd_all_port_storm branch from fa81826 to 7b59f3d Compare January 17, 2025 02:54
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipxu lipxu lipxu approved these changes

@nhe-NV nhe-NV nhe-NV approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Request for 202405 branch Request for 202411 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@echuawu @liat-grozovik @bingwang-ms @yxieca @mssonicbld @nhe-NV @lipxu