-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sonic-mgmt: fix t0-isolated-d128u128s2 topo #15542
sonic-mgmt: fix t0-isolated-d128u128s2 topo #15542
Conversation
In order to have a funtional t0-isolated-d128u128s2 topo, the following changes have been made: - The field 'bp_interfaces' in the t0-isolated-d128u128s2 yml file is corrected to 'bp_interface' i.e. w/o the 's'. - Added more VMs, to support the larger number of VMs needed for the topo. - Added the missing leaf template file for the topo. - Fixed the synthesis of the MACs used in ansible roles so that it does not error out after 256 interfaces.
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
@r12f for viz. |
a few issues is already fixed by this PR: https://github.com/sonic-net/sonic-mgmt/pull/15454/files. this PR is missing the template, because the topo is generated. it will be better to get the generator fixed too. |
@ccroy-arista , this PR is merged now: #15454. you might need to merge with the master branch, and I believe certain issues will be gone. |
This change reduces risk of mac duplication from commit 29b01dd.
The field 'bp_interfaces' in the t0-isolated-d128u128s1 yml file should be 'bp_interface' i.e. w/o the 's'.
Description of PR This PR contains the following changes, in order to achieve a functional t0-isolated-d128u128s2 topo: The field 'bp_interfaces' in the t0-isolated-d128u128s2 yml file is corrected to 'bp_interface' i.e. w/o the 's'. Added more VMs, to support the larger number of VMs needed for the topo. Added the missing leaf template file for the topo. Fixed the synthesis of the MACs used in ansible roles so that it does not error out after 256 interfaces. Additionally, this PR fixed the 'bp_interfaces' for t0-isolated-d128u128s1 yml file.
Description of PR This PR contains the following changes, in order to achieve a functional t0-isolated-d128u128s2 topo: The field 'bp_interfaces' in the t0-isolated-d128u128s2 yml file is corrected to 'bp_interface' i.e. w/o the 's'. Added more VMs, to support the larger number of VMs needed for the topo. Added the missing leaf template file for the topo. Fixed the synthesis of the MACs used in ansible roles so that it does not error out after 256 interfaces. Additionally, this PR fixed the 'bp_interfaces' for t0-isolated-d128u128s1 yml file.
@ccroy-arista PR conflicts with 202405 branch |
A recent merge from a different PR contained a fix that is also present in this PR, hence the conflict with 202405. I will open up a separate PR for 202405 branch. |
The merged cherry-pick to 202405 for sonic-net#15744 mirrors a change in PR sonic-net#15542, which is being blocked from backporting to 202405 as a result. Remove this ansible/roles/eos/templates/t0-isolated-d128u128s2-leaf.j2 so that a 202405 cherry-pick PR can be opened for sonic-net#15542.
PR for manual cherry-pick to 202405 posted: #15786 |
Description of PR
This PR contains the following changes, in order to achieve a functional t0-isolated-d128u128s2 topo:
Additionally, this PR fixed the 'bp_interfaces' for t0-isolated-d128u128s1 yml file.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To achieve a functional t0-isolated-d128u128s2 for use in sonic-mgmt tests.
How did you do it?
Made a series of fixes/updates as detailed in the summary above.
How did you verify/test it?
Confirmed that the testbed server can now be successfully configured as a result of these changes, and subsequently ran the sonic-mgmt test suite.