fix flaky tests/autorestart/test_container_autorestart.py #15526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auspham
changed the title
sdszhang
reviewed
Nov 14, 2024
Signed-off-by: Austin Pham <[email protected]>
sdszhang
approved these changes
Nov 14, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 14, 2024
…15526) Description of PR Summary: Fixes # (issue) Fixes 30114172 Approach What is the motivation for this PR? Increases the threshold timeout for container check for T2 since the BGP neighbor originally was setup to be 360 for T0. However the amount of BGP neighbor is much more comparing to T0. Upons investigation, this test case were flaky because our bgp were still in connecting status. Signed-off-by: Austin Pham <[email protected]>
|
Cherry-pick PR to 202405: #15574 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 15, 2024
Description of PR Summary: Fixes # (issue) Fixes 30114172 Approach What is the motivation for this PR? Increases the threshold timeout for container check for T2 since the BGP neighbor originally was setup to be 360 for T0. However the amount of BGP neighbor is much more comparing to T0. Upons investigation, this test case were flaky because our bgp were still in connecting status. Signed-off-by: Austin Pham <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
…15526) Description of PR Summary: Fixes # (issue) Fixes 30114172 Approach What is the motivation for this PR? Increases the threshold timeout for container check for T2 since the BGP neighbor originally was setup to be 360 for T0. However the amount of BGP neighbor is much more comparing to T0. Upons investigation, this test case were flaky because our bgp were still in connecting status. Signed-off-by: Austin Pham <[email protected]>
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
…15526) Description of PR Summary: Fixes # (issue) Fixes 30114172 Approach What is the motivation for this PR? Increases the threshold timeout for container check for T2 since the BGP neighbor originally was setup to be 360 for T0. However the amount of BGP neighbor is much more comparing to T0. Upons investigation, this test case were flaky because our bgp were still in connecting status. Signed-off-by: Austin Pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue) Fixes 30114172
Type of change
Back port request
Approach
What is the motivation for this PR?
Increases the threshold timeout for container check for T2 since the BGP neighbor originally was setup to be 360 for T0. However the amount of BGP neighbor is much more comparing to T0.
Upons investigation, this test case were flaky because our bgp were still in connecting status.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation