[action] [PR:15249] sonic-mgmt: fix info in testbed_vm_info.py err msg #15523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ansible/library/testbed_vm_info.py, there is a
format string passed to a method without the
actual formatting applied, i.e. the '{}'s are
printed out rather than the desired information
they're supposed to represent. This change
passes the error message to the method with the
correct formatting applied.
8 tasks
|
Original PR: #15249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In ansible/library/testbed_vm_info.py, there is a format string passed to a method without the actual formatting applied, i.e. the '{}'s are printed out rather than the desired information they're supposed to represent. This change passes the error message to the method with the correct formatting applied.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix a mistake that was noticed in the printout of an error message.
How did you do it?
Pass the format string with the appropriate formatting applied to the applicable method, as opposed to the raw format string.
How did you verify/test it?
Tested on 202405 against the t0-isolated-d128u128s2, topology, which at the time of this writing is known to encounter the issue that will result in this error message being printed.
Any platform specific information?
Tested on Arista-7060X6-64PE-C256S2.