Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:15311] fix sample_golden_config_db.j2 portchannel undefined #15521

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mssonicbld
Copy link
Collaborator

Add portchannel check to sample_golden_config_db.j2 to resolve errors for topos (specifically mx) that do not have portchannels for golden_config_infra/test_config_reload_with_rendered_golden_config.py when running sonic-cfggen -d -t /tmp/golden_config_db.j2 > /etc/sonic/golden_config_db.json

Description of PR

Summary:
Fixes #15310

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Fix #15310

How did you do it?

Added portchannel check in sample_golden_config_db.j2 jinja file

How did you verify/test it?

Ran and tested on mx topos with no portchannels defined

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Add portchannel check to sample_golden_config_db.j2 to resolve errors
for topos (specifically mx) that do not have portchannels for
golden_config_infra/test_config_reload_with_rendered_golden_config.py
when running `sonic-cfggen -d -t /tmp/golden_config_db.j2 > /etc/sonic/golden_config_db.json`
@mssonicbld
Copy link
Collaborator Author

Original PR: #15311

@mssonicbld mssonicbld merged commit d524ed3 into sonic-net:202405 Nov 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants