SRv6 uSID BGP L3VPN services #15510

cscarpitta · 2024-11-12T19:00:46Z

Add test cases for SRv6

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Supported testbed topology if it's a new test case?

T0

mssonicbld · 2024-11-12T19:09:21Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/srv6/test_srv6.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/srv6/test_srv6.py:70:13: E127 continuation line over-indented for visual indent tests/srv6/test_srv6.py:111:13: E127 continuation line over-indented for visual indent tests/srv6/test_srv6.py:149:121: E501 line too long (147 > 120 characters) tests/srv6/test_srv6.py:150:121: E501 line too long (135 > 120 characters) tests/srv6/test_srv6.py:159:121: E501 line too long (129 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-11-13T15:44:10Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/srv6/test_srv6.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Passed flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

BYGX-wcr · 2024-11-14T02:24:42Z

@cscarpitta , you should add a test plan file

Signed-off-by: carmine <[email protected]>

Signed-off-by: Carmine Scarpitta <[email protected]>

cscarpitta · 2024-11-15T14:35:04Z

@cscarpitta , you should add a test plan file

@BYGX-wcr Thanks for the review. I added the test plan.

BYGX-wcr · 2024-11-18T20:08:46Z

tests/srv6/test_srv6.py

+    cmd = "redis-cli -n 0  hgetall \"SRV6_SID_LIST_TABLE:Vrf10:{}\"".format(V6_PREFIX_NBR)
+    result = duthost.shell(cmd)
+    result = result['stdout']
+    Logger.info("Route table nexthops are %s", result)


The log statements seems to be not updated accordingly? You are checking SID_LIST_TABLE here right? The log statement for MY_SID table seems to be not correct as well.

Yes, indeed the log statement was incorrect. I fixed it. Thanks.

BYGX-wcr · 2024-11-18T20:10:29Z

tests/srv6/test_srv6.py

+           " -c 'exit'"
+           " -c 'exit'"
+           " -c 'exit'"
+           " -c 'router bgp 64600'"


Where do we configure the BGP session in this FRR config?

In the FRR config, the line below configures the BGP session with the other node.

-c 'neighbor 2001:db8:2::1 remote-as 65100'

BYGX-wcr · 2024-11-18T20:12:17Z

tests/srv6/test_srv6.py

+    duthost.shell(cmd)
+    cmd = "config interface vrf bind Loopback1 Vrf10"
+    duthost.shell(cmd)
+    cmd = "config interface ip add Loopback1 2001:db8:2::1"


although this may not have any functional impact, but we'd better use a different Loopback address for DUT instead of reusing the Loopback address.

I agree with your point. I assigned the neighbor a Loopback address different from the DUT

BYGX-wcr · 2024-11-18T20:12:58Z

tests/srv6/test_srv6.py

+    result = result['stdout']
+    Logger.info("Route table nexthops are %s", result)
+    py_assert(result != "", "The DUT did not program SRv6 MySid entry")
+    py_assert("action: udt6" not in result, "The DUT did not program SRv6 MySid entry, missing 'action' field")


where do you configure the udt6 action?

uDT6 SID is created automatically by BGP.

When you set sid vpn export auto under the address-family ipv6 unicast section in the FRR config, BGP automatically creates the uDT6 SID.

Signed-off-by: Carmine Scarpitta <[email protected]>

…the Loopback address of DUT Signed-off-by: Carmine Scarpitta <[email protected]>

mssonicbld · 2025-01-14T18:49:55Z

/azp run

azure-pipelines · 2025-01-14T18:50:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…the Loopback address of DUT Signed-off-by: Carmine Scarpitta <[email protected]>

mssonicbld · 2025-01-14T18:53:57Z

/azp run

azure-pipelines · 2025-01-14T18:54:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Carmine Scarpitta <[email protected]>

mssonicbld · 2025-01-14T20:28:04Z

/azp run

azure-pipelines · 2025-01-14T20:28:18Z

Azure Pipelines successfully started running 1 pipeline(s).

BYGX-wcr · 2025-01-14T22:17:16Z

Hi @cscarpitta,

Two issues:

You did not clean up the config you added to the DUT. That would cause side-effect to the DUT, which is discouraged
I tried running your test with 202412 image and failed to see any SID_LIST or SIDs in the APPL_DB. Is there any special requirement for the image?

cscarpitta marked this pull request as draft November 12, 2024 19:06

cscarpitta force-pushed the test_srv6 branch from 535afcd to 8a496ac Compare November 13, 2024 15:42

cscarpitta marked this pull request as ready for review November 13, 2024 15:43

cscarpitta force-pushed the test_srv6 branch from 8a496ac to 6f4a59a Compare November 13, 2024 15:49

kperumalbfn mentioned this pull request Nov 13, 2024

[fpmsyncd]: Add support for SRv6 sonic-net/sonic-swss#3123

Merged

cscarpitta force-pushed the test_srv6 branch from 6f4a59a to 684f29f Compare November 14, 2024 16:59

cscarpitta requested review from wangxin and yxieca as code owners November 14, 2024 16:59

cscarpitta added 2 commits November 15, 2024 08:28

Add SRv6 test cases

130efb5

Signed-off-by: carmine <[email protected]>

Add SRv6 test plan

0fb8022

Signed-off-by: Carmine Scarpitta <[email protected]>

cscarpitta force-pushed the test_srv6 branch from 684f29f to 0fb8022 Compare November 15, 2024 14:29

BYGX-wcr reviewed Nov 18, 2024

View reviewed changes

cscarpitta changed the title ~~Add SRv6 test cases~~ SRv6 uSID BGP L3VPN services Jan 14, 2025

ahsalam approved these changes Jan 14, 2025

View reviewed changes

cscarpitta added 3 commits January 14, 2025 19:47

Rename test to "SRv6 uSID BGP L3VPN Services"

c949eeb

Signed-off-by: Carmine Scarpitta <[email protected]>

Fix logs

caa853c

Signed-off-by: Carmine Scarpitta <[email protected]>

Use a different loopback address for the neighbor instead of reusing …

e0a8962

…the Loopback address of DUT Signed-off-by: Carmine Scarpitta <[email protected]>

Use a different loopback address for the neighbor instead of reusing …

607be4e

…the Loopback address of DUT Signed-off-by: Carmine Scarpitta <[email protected]>

Fix style warnings

5bc41f6

Signed-off-by: Carmine Scarpitta <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SRv6 uSID BGP L3VPN services #15510

SRv6 uSID BGP L3VPN services #15510

cscarpitta commented Nov 12, 2024

mssonicbld commented Nov 12, 2024

mssonicbld commented Nov 13, 2024

BYGX-wcr commented Nov 14, 2024

cscarpitta commented Nov 15, 2024

BYGX-wcr Nov 18, 2024

cscarpitta Jan 14, 2025

BYGX-wcr Nov 18, 2024

cscarpitta Jan 14, 2025

BYGX-wcr Nov 18, 2024

cscarpitta Jan 14, 2025

BYGX-wcr Nov 18, 2024

cscarpitta Jan 14, 2025

mssonicbld commented Jan 14, 2025

azure-pipelines bot commented Jan 14, 2025

mssonicbld commented Jan 14, 2025

azure-pipelines bot commented Jan 14, 2025

mssonicbld commented Jan 14, 2025

azure-pipelines bot commented Jan 14, 2025

BYGX-wcr commented Jan 14, 2025

SRv6 uSID BGP L3VPN services #15510

Are you sure you want to change the base?

SRv6 uSID BGP L3VPN services #15510

Conversation

cscarpitta commented Nov 12, 2024

Type of change

Supported testbed topology if it's a new test case?

mssonicbld commented Nov 12, 2024

mssonicbld commented Nov 13, 2024

BYGX-wcr commented Nov 14, 2024

cscarpitta commented Nov 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mssonicbld commented Jan 14, 2025

azure-pipelines bot commented Jan 14, 2025

mssonicbld commented Jan 14, 2025

azure-pipelines bot commented Jan 14, 2025

mssonicbld commented Jan 14, 2025

azure-pipelines bot commented Jan 14, 2025

BYGX-wcr commented Jan 14, 2025