change swapsyncd to module level. #15501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable ipv6 at module level too
|
Test result. 2 failures are known issue, 1 error was due to testbed issue, not related to this change. All other test cases passed on T2 setup. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 7, 2024
Description of PR Summary: change swapsyncd and disable_ipv6 to module level. Running time on T2 reduced by around 140 minutes (from 685.08 minutes to 543.95 minutes). Existing code will do swapSyncd for selected dut only in each iteration. In a T2 full test, it was around 8 LC which needs to do swapsyncd, including setup and teardown for each iteration. select_src_dst_dut_and_asic selected DUT to do swapsyncd (Existing) single_asic one downstream LC single_dut_multi_asic one downstream LC multi_dut_longlink_to_shortlink one upstream LC, one downstream LC multi_dut_shortlink_to_shortlink two downstream LC multi_dut_shortlink_to_longlink one upstream LC, one downstream LC After the fix, swapsyncd will be done for all LCs at the beginning of the test. Saved around 5 LC swapsyncd time select_src_dst_dut_and_asic selected DUT to do swapsyncd (after fix) Setup one upstream LC, two downstream LC single_asic none single_dut_multi_asic none multi_dut_longlink_to_shortlink none multi_dut_shortlink_to_shortlink none multi_dut_shortlink_to_longlink none Teardown one upstream LC, two downstream LC Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Reduce the run time for test_qos_sai module. How did you do it? change the swapsyncd fixture to module level. replace all dut with rpcsyncd container, instead of replacing selected dut multiple times for each iteration. How did you verify/test it? verified the physical testbed. co-authorized by: [email protected]
|
Cherry-pick PR to 202405: #15938 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 7, 2024
Description of PR Summary: change swapsyncd and disable_ipv6 to module level. Running time on T2 reduced by around 140 minutes (from 685.08 minutes to 543.95 minutes). Existing code will do swapSyncd for selected dut only in each iteration. In a T2 full test, it was around 8 LC which needs to do swapsyncd, including setup and teardown for each iteration. select_src_dst_dut_and_asic selected DUT to do swapsyncd (Existing) single_asic one downstream LC single_dut_multi_asic one downstream LC multi_dut_longlink_to_shortlink one upstream LC, one downstream LC multi_dut_shortlink_to_shortlink two downstream LC multi_dut_shortlink_to_longlink one upstream LC, one downstream LC After the fix, swapsyncd will be done for all LCs at the beginning of the test. Saved around 5 LC swapsyncd time select_src_dst_dut_and_asic selected DUT to do swapsyncd (after fix) Setup one upstream LC, two downstream LC single_asic none single_dut_multi_asic none multi_dut_longlink_to_shortlink none multi_dut_shortlink_to_shortlink none multi_dut_shortlink_to_longlink none Teardown one upstream LC, two downstream LC Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Reduce the run time for test_qos_sai module. How did you do it? change the swapsyncd fixture to module level. replace all dut with rpcsyncd container, instead of replacing selected dut multiple times for each iteration. How did you verify/test it? verified the physical testbed. co-authorized by: [email protected]
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 2, 2025
Description of PR Summary: change swapsyncd and disable_ipv6 to module level. Running time on T2 reduced by around 140 minutes (from 685.08 minutes to 543.95 minutes). Existing code will do swapSyncd for selected dut only in each iteration. In a T2 full test, it was around 8 LC which needs to do swapsyncd, including setup and teardown for each iteration. select_src_dst_dut_and_asic selected DUT to do swapsyncd (Existing) single_asic one downstream LC single_dut_multi_asic one downstream LC multi_dut_longlink_to_shortlink one upstream LC, one downstream LC multi_dut_shortlink_to_shortlink two downstream LC multi_dut_shortlink_to_longlink one upstream LC, one downstream LC After the fix, swapsyncd will be done for all LCs at the beginning of the test. Saved around 5 LC swapsyncd time select_src_dst_dut_and_asic selected DUT to do swapsyncd (after fix) Setup one upstream LC, two downstream LC single_asic none single_dut_multi_asic none multi_dut_longlink_to_shortlink none multi_dut_shortlink_to_shortlink none multi_dut_shortlink_to_longlink none Teardown one upstream LC, two downstream LC Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Reduce the run time for test_qos_sai module. How did you do it? change the swapsyncd fixture to module level. replace all dut with rpcsyncd container, instead of replacing selected dut multiple times for each iteration. How did you verify/test it? verified the physical testbed. co-authorized by: [email protected]
|
Cherry-pick PR to 202411: #16280 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 2, 2025
Description of PR Summary: change swapsyncd and disable_ipv6 to module level. Running time on T2 reduced by around 140 minutes (from 685.08 minutes to 543.95 minutes). Existing code will do swapSyncd for selected dut only in each iteration. In a T2 full test, it was around 8 LC which needs to do swapsyncd, including setup and teardown for each iteration. select_src_dst_dut_and_asic selected DUT to do swapsyncd (Existing) single_asic one downstream LC single_dut_multi_asic one downstream LC multi_dut_longlink_to_shortlink one upstream LC, one downstream LC multi_dut_shortlink_to_shortlink two downstream LC multi_dut_shortlink_to_longlink one upstream LC, one downstream LC After the fix, swapsyncd will be done for all LCs at the beginning of the test. Saved around 5 LC swapsyncd time select_src_dst_dut_and_asic selected DUT to do swapsyncd (after fix) Setup one upstream LC, two downstream LC single_asic none single_dut_multi_asic none multi_dut_longlink_to_shortlink none multi_dut_shortlink_to_shortlink none multi_dut_shortlink_to_longlink none Teardown one upstream LC, two downstream LC Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? Reduce the run time for test_qos_sai module. How did you do it? change the swapsyncd fixture to module level. replace all dut with rpcsyncd container, instead of replacing selected dut multiple times for each iteration. How did you verify/test it? verified the physical testbed. co-authorized by: [email protected]
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
change swapsyncd and disable_ipv6 to module level.
Running time on T2 reduced by around 140 minutes (from 685.08 minutes to 543.95 minutes).
Existing code will do swapSyncd for selected dut only in each iteration. In a T2 full test, it was around 8 LC which needs to do swapsyncd, including setup and teardown for each iteration.
After the fix, swapsyncd will be done for all LCs at the beginning of the test. Saved around 5 LC swapsyncd time
Type of change
Back port request
Approach
What is the motivation for this PR?
Reduce the run time for test_qos_sai module.
How did you do it?
change the swapsyncd fixture to module level. replace all dut with rpcsyncd container, instead of replacing selected dut multiple times for each iteration.
How did you verify/test it?
verified the physical testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation