-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the advanced reboot test to collect tcpdump on the server physical port #15498
base: master
Are you sure you want to change the base?
Conversation
5e65c43
to
13d2ec3
Compare
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
d58c64c
to
534412c
Compare
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
14db89f
to
961a7df
Compare
@saiarcot895, @Ryangwaite Can you help review this change? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
…ical port Get the tcpdump on the physical interface of the test server instead of the logical ptf interfaces. This is to fix the issue that sometimes there could be random packet drop on the ptf. Keep the original approch to capture on the ptf interfaces for the kvm testbed which doesn't have the vmhost external port.
692b991
to
3f05b65
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of PR
Summary:
We have been observing random packet drops on the ptf in multiple tests, the advanced reboot test also suffers from this.
We suspect it could be some performance issue of the ptf.
For the advanced reboot test, we can avoid it by moving the tcpdump from the logical interfaces in ptf container to the physical interface of the test server(vmhost).
With this change, the random packet drop is no longer observed in this test.
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix the ptf random packet drop issue in the advanced-reboot test.
How did you do it?
By moving the tcpdump from the logical interfaces in ptf container to the physical interface of the test server.
How did you verify/test it?
Run all the advanced reboot tests(fast/warm reboot, upgrade, and etc.) in our internal regression on all the platforms. No issues observed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation