Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nhop_group: Fix expected mac address dictionary for Cisco 8122 #15409

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

ranepbhagyashree
Copy link
Contributor

@ranepbhagyashree ranepbhagyashree commented Nov 6, 2024

Description of PR

Changes to fix failing testcase: test_nhop_group_member_order_capability for Cisco 8122 platform
Created a new dictionary for gr2 asic with the expected mac addresses for 0-49 flows

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Ran sonic-mgmt test suite on Cisco 8122

Any platform specific information?

Specific to Cisco 8122

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ipfwd/test_nhop_group.py:762:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:763:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:764:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:765:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:766:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:767:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:768:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:769:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:770:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:771:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:772:25: E128 continuation line under-indented for visual indent
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

1 similar comment
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/ipfwd/test_nhop_group.py:762:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:763:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:764:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:765:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:766:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:767:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:768:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:769:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:770:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:771:25: E128 continuation line under-indented for visual indent
tests/ipfwd/test_nhop_group.py:772:25: E128 continuation line under-indented for visual indent
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@ranepbhagyashree ranepbhagyashree changed the title gr2_nhop_hmap: Fix gr2 mac address dictionary nhop_group: Fix expected mac address dictionary for Cisco 8122 Nov 7, 2024
bpar9
bpar9 previously approved these changes Nov 7, 2024
Copy link
Contributor

@bpar9 bpar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bpar9
Copy link
Contributor

bpar9 commented Nov 7, 2024

can you remove the internal platform names from the verification section

@ranepbhagyashree
Copy link
Contributor Author

can you remove the internal platform names from the verification section

done

@ranepbhagyashree
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 15409 in repo sonic-net/sonic-mgmt

@bpar9
Copy link
Contributor

bpar9 commented Nov 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bpar9 bpar9 merged commit 9e248f6 into sonic-net:master Nov 13, 2024
15 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 14, 2024
…-net#15409)

* gr2_nhop_hmap: Fix gr2 mac address dictionary

* nhop_group: Fix expected mac address dictionary for Cisco 8122
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15556

mssonicbld pushed a commit that referenced this pull request Nov 14, 2024
* gr2_nhop_hmap: Fix gr2 mac address dictionary

* nhop_group: Fix expected mac address dictionary for Cisco 8122
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
…-net#15409)

* gr2_nhop_hmap: Fix gr2 mac address dictionary

* nhop_group: Fix expected mac address dictionary for Cisco 8122
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
…-net#15409)

* gr2_nhop_hmap: Fix gr2 mac address dictionary

* nhop_group: Fix expected mac address dictionary for Cisco 8122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants