-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cisco-8000 Revise TX XOFF counter check #15400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
rbpittman
changed the title
Revise after XON counter change.
Cisco-8000 Revise XON counter check
Nov 6, 2024
rbpittman
changed the title
Cisco-8000 Revise XON counter check
Cisco-8000 Revise TX XOFF counter check
Nov 6, 2024
kevinskwang
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
Cherry-pick PR to 202311: #15439 |
8 tasks
veronica-arista
pushed a commit
to veronica-arista/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Nov 9, 2024
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
Nov 9, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 13, 2024
Cherry-pick PR to 202405: #15532 |
8 tasks
kevinskwang
pushed a commit
that referenced
this pull request
Nov 15, 2024
Co-authored-by: rbpittman <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Nov 15, 2024
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Follow up on TODO item for when the TX XOFF counter behavior changed for Cisco-8000 series devices.
Needed in 202311 as well, as the TODO code is present there as well.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Verified on Cisco-8111 device to reproduce the xoff !=0 assertion failure consistently, then revised test appropriately for new TX XOFF counter behavior.
Any platform specific information?
Cisco-8000 series test only.
Supported testbed topology if it's a new test case?
Documentation