Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco-8000 Revise TX XOFF counter check #15400

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

rbpittman
Copy link
Contributor

@rbpittman rbpittman commented Nov 6, 2024

Description of PR

Summary:
Follow up on TODO item for when the TX XOFF counter behavior changed for Cisco-8000 series devices.

Needed in 202311 as well, as the TODO code is present there as well.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Verified on Cisco-8111 device to reproduce the xoff !=0 assertion failure consistently, then revised test appropriately for new TX XOFF counter behavior.

Any platform specific information?

Cisco-8000 series test only.

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbpittman rbpittman changed the title Revise after XON counter change. Cisco-8000 Revise XON counter check Nov 6, 2024
@rbpittman rbpittman changed the title Cisco-8000 Revise XON counter check Cisco-8000 Revise TX XOFF counter check Nov 6, 2024
Copy link
Collaborator

@kevinskwang kevinskwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinskwang kevinskwang merged commit 730b79b into sonic-net:master Nov 7, 2024
15 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 7, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #15439

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15532

kevinskwang pushed a commit that referenced this pull request Nov 15, 2024
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants