Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:13290] [T2-Chassis] - New tests for Reliable-TSA feature #15338

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

  • Added 20 new test cases to verify feature in three sets.
  • Attaching test cases' description document here for further reference.
  • Reliable-TSA-Cases.xlsx
  1. First set: TSA/TSB config event on the supervisor or line card. (8 cases)
    test_sup_tsa_act_when_sup_duts_on_tsb_initially
    test_sup_tsa_act_when_sup_on_tsb_duts_on_tsa_initially
    test_sup_tsb_act_when_sup_on_tsa_duts_on_tsb_initially
    test_sup_tsb_act_when_sup_and_duts_on_tsa_initially
    test_dut_tsa_act_when_sup_duts_on_tsb_initially
    test_dut_tsa_act_when_sup_on_tsa_duts_on_tsb_initially
    test_dut_tsb_act_when_sup_on_tsb_duts_on_tsa_initially
    test_dut_tsb_act_when_sup_and_duts_on_tsa_initially

  2. Second set: Config event followed by certain action on the supervisor or line card. (8 cases)
    test_sup_tsa_act_with_sup_reboot
    test_sup_tsa_act_when_duts_on_tsa_with_sup_config_reload
    test_dut_tsa_act_with_reboot_when_sup_dut_on_tsb_init
    test_dut_tsa_with_conf_reload_when_sup_on_tsa_dut_on_tsb_init
    test_sup_tsb_followed_by_dut_bgp_restart_when_sup_on_tsa_duts_on_tsb
    test_sup_tsb_followed_by_dut_bgp_restart_when_sup_and_duts_on_tsa
    test_dut_tsb_followed_by_dut_bgp_restart_when_sup_on_tsb_duts_on_tsa
    test_dut_tsb_followed_by_dut_bgp_restart_when_sup_and_duts_on_tsa

  3. Miscellaneous tests: Use cases with 'startup-tsa-tsb' service etc. (4 cases)
    test_sup_tsa_when_startup_tsa_tsb_service_running
    test_sup_tsb_when_startup_tsa_tsb_service_running
    test_user_init_tsa_on_dut_followed_by_sup_tsa
    test_user_init_tsa_on_dut_followed_by_sup_tsb

How did you verify/test it?

  • Ran all the above-mentioned test cases on a T2 chassis and made sure tests passed with expected behavior.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Reliable TSA test result:
image

Startup-tsa-tsb service test result:
image

Note: PR #12781 is pending merge, and this PR is dependent on that.

@mssonicbld
Copy link
Collaborator Author

Original PR: #13290

Copy link
Contributor

@vperumal vperumal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Validated for 202405 on Cisco Chassis

@vperumal
Copy link
Contributor

vperumal commented Nov 5, 2024

@abdosi @yejianquan - Can we get this merged to 202405

@yejianquan
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit d25a42e into sonic-net:202405 Nov 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants