[action] [PR:15268] Add cEOS neighbor support for bgp/test_4-byte_asn_community.py #15335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-net#15268) Description of PR Summary: Add cEOS neighbor support for test_4-byte_asn_community.py. Current test case only support SONiC neighbors. this PR will improve coverage with more neighbor type. Future works to improve, not in this PR: implement SONiC specific BGP operations in class SonicBGPRouter. and change the current command check method to using class method for BGP configuration/verification. Approach What is the motivation for this PR? Improve test coverage by adding cEOS support to the test case. How did you do it? Defined a base class for common BGP operations. class BGPRouter(ABC):, and implemented platfor specific BGP operations for cEOS neighbors. How did you verify/test it? bgp/test_4-byte_asn_community.py::test_4_byte_asn_community[vlab-01-None] PASSED [100%] co-authorized by: [email protected]
8 tasks
|
Original PR: #15268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add cEOS neighbor support for test_4-byte_asn_community.py. Current test case only support SONiC neighbors. this PR will improve coverage with more neighbor type.
Future works to improve, not in this PR:
SonicBGPRouter. and change the current command check method to using class method for BGP configuration/verification.Type of change
Back port request
Approach
What is the motivation for this PR?
Improve test coverage by adding cEOS support to the test case.
How did you do it?
Defined a base class for common BGP operations.
class BGPRouter(ABC):, and implemented platfor specific BGP operations for cEOS neighbors.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation