[action] [PR:15296] feat: optimise log_rotate for modular chassis #15302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue) 29752643
Type of change
Back port request
Approach
What is the motivation for this PR?
Currently log rotate for supervisor takes 1 to 2 minutes with a maximum of 2 minutes on pc/test_lag_2
Since log_rotate is now running on function fixture. With all test case running, this will add up. On recent nightly run, it added up to
2:03:58
hours which slows down the test to 2 hours.The reason for log rotating is documented in #2161 to save spaces on 7060 devices. This change for T2 device make sure that we only rotate for T2 at
module
level instead of functions.This will optimise the time from 2 hours to 2 minutes.
Details of the stats can be seen here for pc/test_lag_2
Break down of
analyzer_logrotate_time
in detailsComplete everything around 22:10:45
everyone was waiting for sup-1 which goes from
22:08:44 -> 22:10:45
which is around 2 minutes. This is reasonable speed.22:08:44 -> 22:09:03
which is 19 seconds. But we have to wait for supervisor to be done.How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation