Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:15204] [sonic-mgmt][conditional_mark] Remove incorrect quotes around github issue url #15301

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Remove incorrect quotes around github issue url in tests_mark_conditions.yaml file.
Fixes # https://github.com/aristanetworks/sonic-qual.msft/issues/281

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

PR##14912 has introduced single quotes around github issue url and this is causing conditional mark evaluation to fail. Thus conditional mark config is not honored and couple of tests are getting scheduled even though they are supposed to be skipped.

07:58:59 __init__.evaluate_condition L0504 ERROR | Failed to evaluate condition, raw_condition=hwsku in ['Arista-7260CX3-D108C8', 'Arista-7260CX3-Q64', 'Mellanox-SN3800-D112C8'] and 'https://github.com/sonic-net/sonic-mgmt/issues/11237', condition_str=hwsku in ['Arista-7260CX3-D108C8', 'Arista-7260CX3-Q64', 'Mellanox-SN3800-D112C8'] and 'True
Traceback (most recent call last):
 File "/data/sonic-mgmt/tests/common/plugins/conditional_mark/__init__.py", line 499, in evaluate_condition
 condition_result = bool(eval(condition_str, basic_facts))
 File "<string>", line 1
 hwsku in ['Arista-7260CX3-D108C8', 'Arista-7260CX3-Q64', 'Mellanox-SN3800-D112C8'] and 'True
 ^
SyntaxError: EOL while scanning string literal
collected 2 items

How did you do it?

Removed those unnecessary single quotes around the url.

How did you verify/test it?

Ran generic_config_updater/test_eth_interface.py::test_replace_fec and it's getting skipped correctly on Arista-7260CX3-D108C8 platform (currently it's getting scheduled and failing due to PR#14912).

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

PR#14912 has introduced single quotes around github issue url and this
is causing conditional mark evaluation to fail. Thus conditional mark
config is not honored and couple of tests are getting scheduled even
though they are supposed to be skipped.
@mssonicbld
Copy link
Collaborator Author

Original PR: #15204

@mssonicbld mssonicbld merged commit 51b1f49 into sonic-net:202405 Oct 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants