[202405] Stabilize test_cacl cases #15299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stabilize test_cacl_tc1_acl_table_suite when rollback_or_reload the config, we are not sure how long the iptable rule is ready, so use retry mechanism to check if the current iptable rule are equal to the original ones * update the retry time
|
Cherry-pick #14999 |
bingwang-ms
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
After rollback_or_reload the config, the case check if the current iptable rules equal to the original iptale rules directly. Sometimes, the iptable rules are not ready completely, so case will fail due to missing some iptable rules. Therefore, update the code to use retry mechanism to check if the current iptable rules are equal to the original ones.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Stabilize test_cacl cases
How did you do it?
Update the code to use retry mechanism to check if the current iptable rules are equal to the original ones.
How did you verify/test it?
Run test_cacl 20 times
Any platform specific information?
Any
Supported testbed topology if it's a new test case?
Documentation