Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimise log_rotate for modular chassis #15296

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat: optimise log_rotate for modular chassis #15296

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b7e519
feat: optimise log_rotate for modular chassis
auspham Oct 31, 2024
f476003
chore: add comments justifying optimisation reason
auspham Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions tests/common/plugins/loganalyzer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,21 @@ def analyze_logs(analyzers, markers, node=None, results=None, fail_test=True, st
dut_analyzer.analyze(markers[node.hostname], fail_test, store_la_logs=store_la_logs)


@pytest.fixture(scope="module")
def log_rotate_modular_chassis(duthosts, request):
if request.config.getoption("--disable_loganalyzer") or "disable_loganalyzer" in request.keywords:
return

is_modular_chassis = duthosts[0].get_facts().get("modular_chassis")

if not is_modular_chassis:
return

parallel_run(analyzer_logrotate, [], {}, duthosts, timeout=120)


@pytest.fixture(autouse=True)
def loganalyzer(duthosts, request):
def loganalyzer(duthosts, request, log_rotate_modular_chassis):
if request.config.getoption("--disable_loganalyzer") or "disable_loganalyzer" in request.keywords:
logging.info("Log analyzer is disabled")
yield
Expand All @@ -57,7 +70,9 @@ def loganalyzer(duthosts, request):
store_la_logs = request.config.getoption("--store_la_logs")
analyzers = {}
should_rotate_log = request.config.getoption("--loganalyzer_rotate_logs")
if should_rotate_log:

is_modular_chassis = duthosts[0].get_facts().get("modular_chassis")
auspham marked this conversation as resolved.
Show resolved Hide resolved
if should_rotate_log and not is_modular_chassis:
parallel_run(analyzer_logrotate, [], {}, duthosts, timeout=120)
for duthost in duthosts:
analyzer = LogAnalyzer(ansible_host=duthost, marker_prefix=request.node.name)
Expand Down
Loading