Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip RX_DRP check on Mellanox platform in test_drop_l3_ip_packet_non_dut_mac #15248

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)
This PR is to skip RX_DRP counter check on Mellanox platform in test_drop_l3_ip_packet_non_dut_mac.
The packets are dropped silently on Mellanox devices.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

This PR is to skip RX_DRP counter check on Mellanox platform in test_drop_l3_ip_packet_non_dut_mac.

How did you do it?

Check asic_type and skip check of RX_DRP.

How did you verify/test it?

The change is verified on a Mellanox testbed.

collected 1 item                                                                                                                                                                                      

ip/test_ip_packet.py::TestIPPacket::test_drop_l3_ip_packet_non_dut_mac[str2-msn2700-spy-2] PASSED                                                                                               [100%]

Any platform specific information?

Mellanox platform specific.

Supported testbed topology if it's a new test case?

Not a new test.

Documentation

@bingwang-ms
Copy link
Collaborator Author

@echuawu @nhe-NV Please help confirm if the behavior is expected.

Copy link
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms bingwang-ms merged commit 709ebde into sonic-net:master Nov 13, 2024
16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 13, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants