-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCU] [MA] Adding support in existing tests ACL #15188
base: master
Are you sure you want to change the base?
Conversation
@xincunli-sonic Could you please review? |
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
This PR could be dup with #14098, please double check. Thanks! |
logger.info("Test acl table for protocol {}".format(cacl_protocol)) | ||
if cacl_protocol == 'EXTERNAL_CLIENT': | ||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not solving the conflicts.
Description of PR
This PR adds changes for adding Multi-ASIC support for generic config updater (GCU) in existing ACL suites.
Original ticket that got splitted: #14070
This change has a dependency on common changes added via #15182
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To add support for Multi-ASIC testing in existing GCU suite generic_config_updater/test_cacl.py.
How did you do it?
How did you verify/test it?
Ran in vs-kvm-t0 testbed. Ran in t2 MA platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation