Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCU] [MA] Adding support in existing tests - PFCWD #15183

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

okaravasi
Copy link
Contributor

Description of PR

This PR adds the common changes for adding Multi-ASIC support for generic config updater (GCU) in existing suites.
Original ticket that got splitted: #14070
This change has a dependency on common changes added via #15182

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • [X ] Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • [ X] 202405

Approach

What is the motivation for this PR?

To add support for Multi-ASIC testing in existing PFCWD GCU suites.

How did you do it?

How did you verify/test it?

Ran in vs-kvm-t0 testbed. Ran in t2 MA platform.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@okaravasi okaravasi marked this pull request as ready for review October 25, 2024 14:08
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/generic_config_updater/test_pfcwd_interval.py:107:1: E302 expected 2 blank lines, found 1
tests/generic_config_updater/test_pfcwd_status.py:211:9: E122 continuation line missing indentation or outdented
tests/generic_config_updater/test_pfcwd_status.py:212:9: E131 continuation line unaligned for hanging indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@okaravasi
Copy link
Contributor Author

@xincunli-sonic Could you please review?

@xincunli-sonic
Copy link
Contributor

This PR could be dup with #14098, please double check, but you can left non namespace related changes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants