Fixed the failure of test_valid_pfc_frame_with_snappi.py in Cisco DUT #15002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the PFC capture sampling to not detect a XOFF frame being capture. Further the buffer size for capture could be small or big depending on the IXIA model capabaility Hence using continous XOFF injection to avoid overwriting the buffer with XON frames post a XON-XOFF-XON transition
alpeshspatel
approved these changes
Oct 17, 2024
wsycqyz
approved these changes
Oct 22, 2024
kevinskwang
approved these changes
Nov 5, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 5, 2024
…sonic-net#15002) * Fixed the testcase as Cisco DUT generates XON frames. This causes the PFC capture sampling to not detect a XOFF frame being capture. Further the buffer size for capture could be small or big depending on the IXIA model capabaility Hence using continous XOFF injection to avoid overwriting the buffer with XON frames post a XON-XOFF-XON transition * Made !is_cisco do regular else cisco specific
|
Cherry-pick PR to 202405: #15360 |
Merged
8 tasks
veronica-arista
pushed a commit
to veronica-arista/sonic-mgmt
that referenced
this pull request
Nov 7, 2024
…sonic-net#15002) * Fixed the testcase as Cisco DUT generates XON frames. This causes the PFC capture sampling to not detect a XOFF frame being capture. Further the buffer size for capture could be small or big depending on the IXIA model capabaility Hence using continous XOFF injection to avoid overwriting the buffer with XON frames post a XON-XOFF-XON transition * Made !is_cisco do regular else cisco specific
|
@sreejithsreekumaran the auto cherry-pick to 202405 has failures. |
@sdszhang, the failure was due to missing files in the 202405 branch. Now that 15487 is complete, this should be fixed. Could we retrigger this cherry-pick PR, please? |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 13, 2024
…#15002) * Fixed the testcase as Cisco DUT generates XON frames. This causes the PFC capture sampling to not detect a XOFF frame being capture. Further the buffer size for capture could be small or big depending on the IXIA model capabaility Hence using continous XOFF injection to avoid overwriting the buffer with XON frames post a XON-XOFF-XON transition * Made !is_cisco do regular else cisco specific
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
sreejithsreekumaran
added a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
…sonic-net#15002) * Fixed the testcase as Cisco DUT generates XON frames. This causes the PFC capture sampling to not detect a XOFF frame being capture. Further the buffer size for capture could be small or big depending on the IXIA model capabaility Hence using continous XOFF injection to avoid overwriting the buffer with XON frames post a XON-XOFF-XON transition * Made !is_cisco do regular else cisco specific
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
…sonic-net#15002) * Fixed the testcase as Cisco DUT generates XON frames. This causes the PFC capture sampling to not detect a XOFF frame being capture. Further the buffer size for capture could be small or big depending on the IXIA model capabaility Hence using continous XOFF injection to avoid overwriting the buffer with XON frames post a XON-XOFF-XON transition * Made !is_cisco do regular else cisco specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_valid_pfc_frame_with_snappi.py fails in Cisco DUT.
The issue was due to PFC capture sampling not detecting an XOFF frame in the capture.
How did you do it?
Added a new pcap read logic using a custom Cisco specific function to verify a valid PFC frame in the capture.
Hence using continuous XOFF injection to avoid overwriting the buffer with XON frames post a XON-XOFF-XON transition
How did you verify/test it?
Verified on Cisco DUT
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation