Fix conftest rand_one_dut_hostname IndexError #14830
Merged
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the rand_one_dut_hostname and selected_rand_dut fixtures to set rand_one_dut_hostname_var whenever needed, specifically in the case the fixture is dynamically loaded. Removed old method of setting rand_one_dut_hostname_var.
dayouliu1
force-pushed
the
fix-conftest-rand-one-dut-hostname
branch
from
bca7793 to
ef073b7
Compare
|
hi @ZhaohuiS Would you help to take a look? |
|
Duplicated with #14935 |
|
@dayouliu1 did you verify your changes by running nightly test? What's test results for |
|
@ZhaohuiS Yes, the above tests passes from the results I see |
@dayouliu1 please paste the test result, thanks. |
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
Updated the rand_one_dut_hostname and selected_rand_dut fixtures to set rand_one_dut_hostname_var whenever needed, specifically in the case the fixture is dynamically loaded. Removed old method of setting rand_one_dut_hostname_var.
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
Updated the rand_one_dut_hostname and selected_rand_dut fixtures to set rand_one_dut_hostname_var whenever needed, specifically in the case the fixture is dynamically loaded. Removed old method of setting rand_one_dut_hostname_var.
|
Can this PR be backported to 202405 please? Just for consistency. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 12, 2024
Updated the rand_one_dut_hostname and selected_rand_dut fixtures to set rand_one_dut_hostname_var whenever needed, specifically in the case the fixture is dynamically loaded. Removed old method of setting rand_one_dut_hostname_var.
|
Cherry-pick PR to 202405: #16047 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 12, 2024
Updated the rand_one_dut_hostname and selected_rand_dut fixtures to set rand_one_dut_hostname_var whenever needed, specifically in the case the fixture is dynamically loaded. Removed old method of setting rand_one_dut_hostname_var.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #14829
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix issue where
rand_one_dut_hostnamefixture was not being properly set when the fixture is loaded dynamically, like in the case forecmp/test_ecmp_hash_seed_value. Thecustom_fixtureplugin will dynamically addrand_one_dut_hostname, but the current method of settingrand_one_dut_hostname_vardoes not account for this and so it is not set.How did you do it?
Set the global variable within the
rand_one_dut_hostnamefixture directly.How did you verify/test it?
Ran and verified test suite
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation