Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute_reboot dbus_interface #164

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

vvolam
Copy link
Contributor

@vvolam vvolam commented Sep 13, 2024

As part of sonic-net/sonic-gnmi#286 changes, we require dbus support for executing HALT method.

This PR adds support for execute_reboot for invoking reboot methods.

Copy link
Contributor

@hdwhdw hdwhdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits not particularly related to this PR.

tests/host_modules/systemd_service_test.py Outdated Show resolved Hide resolved
tests/host_modules/systemd_service_test.py Outdated Show resolved Hide resolved
@vvolam vvolam requested a review from qiluo-msft September 18, 2024 22:29
@saiarcot895
Copy link
Contributor

Please update the tests.

@vvolam
Copy link
Contributor Author

vvolam commented Sep 19, 2024

/azpw run

@mssonicbld
Copy link

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

tests/host_modules/systemd_service_test.py Outdated Show resolved Hide resolved
host_modules/systemd_service.py Outdated Show resolved Hide resolved
@vvolam
Copy link
Contributor Author

vvolam commented Nov 1, 2024

@qiluo-msft could you please review?

@qiluo-msft qiluo-msft merged commit ff73070 into sonic-net:master Nov 8, 2024
5 checks passed
@vvolam vvolam deleted the exec_reboot branch November 8, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants