Install advancetls package to support crl. #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run sonic-net.sonic-gnmi |
|
/AzurePipelines run sonic-net.sonic-gnmi |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
changed the title
|
/azpw run sonic-net.sonic-gnmi |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
commented
Nov 18, 2024
| @@ -69,28 +69,53 @@ go-deps-clean: | |||
| $(RM) -r vendor | |||
|
|
|||
| sonic-gnmi: $(GO_DEPS) | |||
| # advancetls 1.0.0 release need following patch to build by go-1.19 | |||
| # patch -d vendor -p0 < patches/0002-Fix-advance-tls-build-with-go-119.patch | |||
There was a problem hiding this comment.
Will enable this line in next PR: https://github.com/sonic-net/sonic-gnmi/pull/269/files
ganglyu
approved these changes
Nov 18, 2024
|
Will verify with this image: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install advancetls package to support crl.
Why I did it
Support certificate revocation list.
How I did it
Install advancetls package to support crl.
Improve make file.
How to verify it
Manually test.
Add new UT.
Work item tracking
Microsoft ADO (number only): 27146924
Which release branch to backport (provide reason below if selected)
Description for the changelog
Upgrade crypto package to v0.24.0 to support crl
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)