Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore translib related get/set test cases #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sachinholla
Copy link
Contributor

@sachinholla sachinholla commented May 12, 2024

Why I did it

It appears that pipeline tests were failing after recent openconfig-interface related changes in sonic-mgmt-common repo. All such tests were commented out earlier.

How I did it

  • Removed unknown PORT table fields in the testdata/db_dump.json file, which was causing cvl errors during gNMI set tests
  • Revert commits 16c2975, 0e4ac4d, 8494e90, bd74b09 (partial). All gNMI get and set tests are enabled back. Subscription tests are skipped because the new openconfig-interfaces.yang handler is yet to support subscription.
  • Increase client timeout for get /interfaces test case -- the new handler is taking more time to process this request

How to verify it

Pipeline checks

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

@sachinholla sachinholla force-pushed the transl_ut branch 7 times, most recently from 4bfa99b to e6aa2e7 Compare May 13, 2024 04:19
@sachinholla sachinholla changed the title Translib ut experiments -- DO NOT MERGE Restore few translib related test cases May 13, 2024
@sachinholla sachinholla changed the title Restore few translib related test cases Restore translib related get/set test cases May 13, 2024
@sneelam20 sneelam20 self-requested a review September 11, 2024 21:30
sneelam20
sneelam20 previously approved these changes Sep 11, 2024
@sneelam20
Copy link
Contributor

Please resolve conflicts.

* Remove invalid PORT table fields from testdata/db_dump.json
* Revert commits 16c2975, 0e4ac4d, 8494e90, bd74b09 (partial).
  Subscription related tests are not enabled because the new handler
  of openconfig-interfaces.yang does not support subscription yet.

Signed-off-by: Sachin Holla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants