Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor server certificate/key and restart gnmi server when rotated #175

Closed
wants to merge 18 commits into from

Conversation

zbud-msft
Copy link
Contributor

@zbud-msft zbud-msft commented Dec 12, 2023

This PR will be after #179

Why I did it

Add

  • Goroutine within telemetry process to monitor server key and server certificate. If the certificates have been modified, restart gnmi server using new certificates.
  • Refactor telemetry.go such that we are not using global variables and instead pass a local copy of config that is created via flag parsing
  • Add UT for all telemetry.go features such as flag parsing, starting gnmi server, and monitoring certificates

How I did it

Added appropriate goroutines and UT

How to verify it

UT/manual

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@zbud-msft zbud-msft changed the title Monitor acms certs [Draft] Monitor certs Dec 12, 2023
@zbud-msft
Copy link
Contributor Author

/azp run

@zbud-msft zbud-msft marked this pull request as ready for review January 10, 2024 22:04
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zbud-msft zbud-msft changed the title [Draft] Monitor certs Monitor server certificate/key and restart gnmi server when rotated Jan 10, 2024
@qiluo-msft qiluo-msft requested a review from ganglyu January 10, 2024 23:47
@zbud-msft zbud-msft closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant