Support for YANG RPCs #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faraazbrcm
force-pushed
the
rpc_from_proto
branch
6 times, most recently
from
86250a3 to
f26f194
Compare
sachinholla
reviewed
Nov 23, 2023
| TOP_DIR := $(abspath ..) | ||
| MGMT_COMMON_DIR := $(TOP_DIR)/sonic-mgmt-common | ||
| TOPDIR := . | ||
| MGMT_COMMON_DIR := $(TOPDIR)/../sonic-mgmt-common |
There was a problem hiding this comment.
MGMT_COMMON_DIR must be an absolute path.. It is used to set env variables like CVL_SCHEMA_PATH etc, used during gotests
There was a problem hiding this comment.
Thanks @sachinholla . corrected..
faraazbrcm
force-pushed
the
rpc_from_proto
branch
2 times, most recently
from
260d7be to
150ffe6
Compare
faraazbrcm
force-pushed
the
rpc_from_proto
branch
3 times, most recently
from
06ba032 to
cfc2fc8
Compare
|
@kwangsuk please review |
kwangsuk
reviewed
Jan 18, 2024
faraazbrcm
force-pushed
the
rpc_from_proto
branch
from
cfc2fc8 to
19ef472
Compare
|
Can you pls update go.mod and go.sum? |
kwangsuk
reviewed
Mar 4, 2024
kwangsuk
reviewed
Mar 4, 2024
kwangsuk
reviewed
Mar 4, 2024
kwangsuk
reviewed
Mar 4, 2024
kwangsuk
reviewed
Mar 4, 2024
kwangsuk
reviewed
Mar 4, 2024
|
Can you please update the following items?
|
The YANG RPC is supported using gNOI. The protobufs are auto-generated as part of build from YANG files. The gNOI clients also gets built.
faraazbrcm
force-pushed
the
rpc_from_proto
branch
from
19ef472 to
913c789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YANG RPC is supported using gNOI.
The protobufs are auto-generated as part of build from YANG files. The gNOI clients also gets built.
Why I did it
This PR brings in support for YANG RPCs in sonic-gnmi service via gNOI.
How I did it
Generated protobufs from YANG RPCs this is done using pyang plugin and it is hooked up in the sonic-gnmi build.
Protobufs contain RPCs which can be invoked using gNOI.
How to verify it
The gnoi_client application exposes the RPCs generated from YANG, this can be used to verify them.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)