Add delete field to On change response when key is deleted #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbud-msft
force-pushed
the
add_delete_field
branch
from
fd73da5 to
b84845e
Compare
qiluo-msft
reviewed
Jul 25, 2023
qiluo-msft
previously approved these changes
Jul 28, 2023
FengPan-Frank
previously approved these changes
Jul 28, 2023
qiluo-msft
reviewed
Aug 1, 2023
gnmi_server/server_test.go
Outdated
| q.NotificationHandler = func(n client.Notification) error { | ||
| if nn, ok := n.(client.Update); ok { | ||
| nn.TS = time.Unix(0, 200) | ||
| mutexNoti.Lock() |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=6)
Mix tabs and spaces #Closed
qiluo-msft
reviewed
Aug 1, 2023
gnmi_server/server_test.go
Outdated
| mutexNoti.Unlock() | ||
|
|
||
| mutexNoti.RLock() | ||
| gotNoti = append(currentNoti, nn) |
There was a problem hiding this comment.
[](http://example.com/codeflow?start=0&length=6)
The same #Closed
qiluo-msft
approved these changes
Aug 1, 2023
6 tasks
sachinholla
reviewed
Oct 10, 2023
|
|
||
| // Delete to be used to indicate that node was deleted | ||
| []gnmi.Path delete = 8; |
There was a problem hiding this comment.
This is an incorrect syntax. It should have been repeated gnmi.Path delete = 8. I opened PR #157 to fix.
Please do not update the sonic_internal.pb.go file manually when the proto file was modified. Run make proto/sonic_internal.pb.go to re-generate it, which will report all syntax errors in the proto file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently when node is deleted, we do not send a delete field which should be the case according to gnmi specification:
https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-specification.md#21-reusable-notification-message-format
How I did it
Added delete field
How to verify it
UT
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)