Return Grpc.Internal error once there's socker read timeout issue occurs in streaming subscribe under routing flap case #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
May 18, 2023
FengPan-Frank
force-pushed
the
fenpan_pubsubfix
branch
2 times, most recently
from
fc40d5d to
cdfda65
Compare
sallylsy
approved these changes
May 26, 2023
FengPan-Frank
changed the title
FengPan-Frank
changed the title
|
Please rebase and add test coverage to unblock the merge. |
qiluo-msft
reviewed
Jun 2, 2023
FengPan-Frank
force-pushed
the
fenpan_pubsubfix
branch
8 times, most recently
from
01f6473 to
3a7c780
Compare
FengPan-Frank
force-pushed
the
fenpan_pubsubfix
branch
from
3a7c780 to
cd34766
Compare
FengPan-Frank
changed the title
FengPan-Frank
force-pushed
the
fenpan_pubsubfix
branch
2 times, most recently
from
359fe0b to
c45e54a
Compare
**Why I did it** [Semgrep](https://github.com/returntocorp/semgrep) is a static analysis tool to find security vulnerabilities. When opening a PR or commtting to PR, Semgrep performs a diff-aware scanning, which scans changed files in PRs. When merging PR, Semgrep performs a full scan on master branch and report all findings. Ref: - [Supported Language](https://semgrep.dev/docs/supported-languages/#language-maturity) - [Semgrep Rules](https://registry.semgrep.dev/rule) **How I did it** Integrate Semgrep into this repository by committing a job configuration file
FengPan-Frank
force-pushed
the
fenpan_pubsubfix
branch
2 times, most recently
from
bfa44cb to
1475110
Compare
…into fenpan_pubsubfix
FengPan-Frank
force-pushed
the
fenpan_pubsubfix
branch
from
1475110 to
3286382
Compare
Done. |
ganglyu
reviewed
Jun 28, 2023
| MockFail++ | ||
| fmt.Printf("mock sleep for redis timeout\n") | ||
| time.Sleep(30 * time.Second) | ||
| } |
There was a problem hiding this comment.
Can you use gomonkey to replace MockFail?
qiluo-msft
reviewed
Jun 30, 2023
| @@ -207,6 +208,10 @@ func (c *Client) Run(stream gnmipb.GNMI_SubscribeServer) (err error) { | |||
| c.Close() | |||
| // Wait until all child go routines exited | |||
| c.w.Wait() | |||
| if strings.Contains(err.Error(), "i/o timeout") { | |||
There was a problem hiding this comment.
Right, but seems this will require NOT small changes, like now we're using priorityQueue in all db_client which only stores error messages, refer
sonic-gnmi/sonic_data_client/db_client.go
Line 833 in 01fe667
|
Can you add steps to reproduce issue in description? |
qiluo-msft
reviewed
Jul 11, 2023
| @@ -744,6 +745,12 @@ func tableData2Msi(tblPath *tablePath, useKey bool, op *string, msi *map[string] | |||
| return nil | |||
| } | |||
|
|
|||
| if MockFail == 1 { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently streaming telemetry subscribe will hit some error under routing flap case if it subscribes APPL_DB ROUTE_TABLE, this change will return explicit error code to client without any handling.
pubsub notification to avoid inconsistency introduced by other concurrent cmd
Why I did it
When there's DB table flapping happens, like APPL_DB ROUTE_Table, current gnmi server has some performance issue which will result in below error
"read unix @->/var/run/redis/redis.sock: i/o timeout"
We should need to fix this systemically. Now the fix is to return explicit error code as Internal error to client, and later we will do some optimization, and add some retry strategy into the redis function call.
How I did it
Return Grpc.Internal error to the client
How to verify it
verified via gnmi_cli, meanwhile some tests which introduces bgp flapping.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)