Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-cfggen] Fix init t1 config to align with YANG #21195

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Dec 17, 2024

Why I did it

Improve the t1 config to align with YANG validation

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add missing leafref and mandatory field to the config

How to verify it

YANG validation check on generated config

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587
Copy link
Contributor Author

wen587 commented Dec 17, 2024

/azpw ms_conflict

This reverts commit 32692ea.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587
Copy link
Contributor Author

wen587 commented Dec 17, 2024

/azp run Azure.sonic-buildimage

Copy link

Commenter does not have sufficient privileges for PR 21195 in repo sonic-net/sonic-buildimage

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wen587 wen587 marked this pull request as ready for review December 18, 2024 08:34
@wen587 wen587 requested a review from qiluo-msft December 18, 2024 08:34
@lguohan lguohan added the YANG YANG model related changes label Dec 19, 2024
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not add extra empty lines.

@qiluo-msft
Copy link
Collaborator

def generate_t1_sample_config(data):

How to prevent regression in future? Could you add a yang validation into unit test?


Refers to: src/sonic-config-engine/config_samples.py:49 in 051a6ee. [](commit_id = 051a6ee, deletion_comment = False)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Request for 202411 Branch YANG YANG model related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants