GNOI Cold Reboot #20243
Closed
GNOI Cold Reboot #20243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkavitha-hcl
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
rkavitha-hcl
force-pushed
the
patch1_branch
branch
2 times, most recently
from
1d01b3e to
b515022
Compare
rkavitha-hcl
force-pushed
the
patch1_branch
branch
from
b515022 to
e738c37
Compare
kishanps
reviewed
Sep 25, 2024
.gitmodules
Outdated
| path = src/sonic-framework/gnoi | ||
| url = https://github.com/openconfig/gnoi | ||
| [submodule "gnoi"] | ||
| path = gnoi |
Makefile.work
Outdated
| @@ -193,7 +193,7 @@ SONIC_OVERRIDE_BUILD_VARS += SONIC_VERSION_CACHE=$(SONIC_VERSION_CACHE) | |||
| SONIC_OVERRIDE_BUILD_VARS += SONIC_VERSION_CACHE_SOURCE=$(SONIC_VERSION_CACHE_SOURCE) | |||
| export SONIC_VERSION_CACHE SONIC_VERSION_CACHE_SOURCE | |||
| $(shell test -d $(SONIC_VERSION_CACHE_SOURCE) || \ | |||
| mkdir -p $(SONIC_VERSION_CACHE_SOURCE) && chmod -f 777 $(SONIC_VERSION_CACHE_SOURCE) 2>/dev/null ) | |||
| sudo mkdir -p $(SONIC_VERSION_CACHE_SOURCE) && chmod -f 777 $(SONIC_VERSION_CACHE_SOURCE) 2>/dev/null ) | |||
| @@ -17,9 +17,10 @@ libicu67==67.1-7 | |||
| libipt2==2.0.3-1 | |||
| libmpfr6==4.1.0-3 | |||
| libnsl-dev==1.3.0-2 | |||
| libprotobuf-dev==3.12.4-1+deb11u1 | |||
There was a problem hiding this comment.
I am not sure if gbsyncd-broncos and syncd-pensando changes are really required. Pls try to remove these 2 file changes and build a sonic-vs to see if build can go thru.
| @@ -6,12 +6,12 @@ libgrpc++1==1.30.2-3 | |||
| libgrpc-dev==1.30.2-3 | |||
| libgrpc10==1.30.2-3 | |||
| libkmod2==28-1 | |||
| libprotobuf-dev==3.12.4-1+deb11u1 | |||
| @@ -11,7 +11,8 @@ $(DOCKER_SONIC_VS)_DEPENDS += $(SYNCD_VS) \ | |||
| $(LIBYANG_CPP) \ | |||
There was a problem hiding this comment.
gnoi sub module at root level should not exist.
|
|
||
| int main(int argc, char** argv) { | ||
| HostServiceDbus dbus_interface; | ||
| //CriticalState critical_interface; |
| std::copy(m_missing_registrations.begin(), m_missing_registrations.end(), | ||
| std::ostream_iterator<std::string>(stream, ",")); | ||
| return stream.str(); | ||
| } |
|
|
||
| friend class RedisTest; | ||
| }; | ||
|
|
| } | ||
| } */ | ||
|
|
||
| } // namespace rebootbackend |
There was a problem hiding this comment.
John: Is Telemetry interface required ?
There was a problem hiding this comment.
Can you be more specific? I don't know what you mean by Telemetry interface.
| @@ -0,0 +1,60 @@ | |||
| INCLUDES = -I $(top_srcdir) -I $(top_srcdir)/rebootbackend -I $(top_srcdir)/rebootbackend/system | |||
rkavitha-hcl
force-pushed
the
patch1_branch
branch
from
dac19c4 to
cfb6c8c
Compare
|
'/azpw ms_conflict' |
|
/azpw ms_conflict |
rkavitha-hcl
force-pushed
the
patch1_branch
branch
5 times, most recently
from
6e56b56 to
1b4823f
Compare
rkavitha-hcl
force-pushed
the
patch1_branch
branch
from
88ef347 to
a71fb49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)