[Mellanox] Remove pmon delay for certain platforms #19190
Conversation
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
liat-grozovik
changed the title
|
@yxieca can you help to handle ms_conflict and re trigger? |
|
@stepanblyschak please check #18926 and if this PR need to be updated now with it?cccccbkv |
|
/azpw ms_conflict |
|
@vaibhavhd @prgeor Is this a must have for 202405? The change is on all Mellanox platform. |
* [nvidia] Remove pmon delay for certain platforms Signed-off-by: Stepan Blyschak <[email protected]>
|
@bingwang-ms , @vaibhavhd , @prgeor - Can you please cherry pick to 202405 ? |
|
Discussed offline, we are good to cherry-pick it. |
* [nvidia] Remove pmon delay for certain platforms Signed-off-by: Stepan Blyschak <[email protected]>
|
Cherry-pick PR to 202405: #19754 |
* [nvidia] Remove pmon delay for certain platforms Signed-off-by: Stepan Blyschak <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
|
This only works for the Mellanox platform. For other platforms, it would always delay pmon and cause a problem. sonic-net/sonic-platform-daemons#531. |
|
@chiourung The issue is know and a day one xcvrd issue - #17943. Even if we remove the delay it does not fix the problem but makes it very unlikelly, need to fix a race condition |
- Why I did it After this pull request #19190 , the pmon has been added to the start list in fast/warm reboot scenarios. However, certain non-critical daemons of pmon could be delayed, resulting in a saving of approximately 1 second in the reboot process. For performance considerations, especially as the current time usage of fast reboot is closer to 30 seconds limitation, this change could ease the pressure. - How I did it add a script as fast/warm reboot monitor and relative supervisord rlues. once the script exited means the reboot process has ended, other delayed daemon would then initialize. - How to verify it check the fast/warm reboot time usage Signed-off-by: Yuanzhe, Liu <[email protected]>
Why I did it
For doing fast-reboot with CMIS active modules.
Work item tracking
How I did it
Removed PMON delay for SKUs with support for CMIS active modules
How to verify it
Run fast-reboot test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)