Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eventd]Disabling eventd unit tests #17053

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[eventd]Disabling eventd unit tests #17053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sonic-eventd/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ endif
-include rsyslog_plugin/subdir.mk
-include rsyslog_plugin_tests/subdir.mk

all: sonic-eventd eventd-tests eventd-tool rsyslog-plugin rsyslog-plugin-tests
all: sonic-eventd eventd-tool rsyslog-plugin
Copy link
Contributor

@StormLiangMS StormLiangMS Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a mistake to disable rsyslog-plugin-tests? @dgsudharsan

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @StormLiangMS We have build failures when compiling sonic-eventd target and I disabled all unit tests under this target.

Copy link
Contributor

@zbud-msft zbud-msft Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, there is no issue with rsyslog-plugin tests only with eventd-tests. My plan is to revert this PR once I can prove that there is no flakiness with tests with my fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zbud-msft pls let me know when your fix is ready.


sonic-eventd: $(OBJS)
@echo 'Building target: $@'
Expand Down