Fix supervisor-proc-exit-listener false alert during warm reboot issue. #16742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Oct 2, 2023
| status, | ||
| namespace, | ||
| dead_minutes) | ||
| if is_warm_reboot(): |
There was a problem hiding this comment.
Fixed, only ignore error log for orchagent stuck during warm reboot.
There was a problem hiding this comment.
Seems like WARM_RESTART_ENABLE_TABLE is the indicator for warm-boot-up, not warm-shutdown which is what you want. I am considering orchagent process has the full visibility of freezing status, how about continuing hearbeat even when it is frozen?
Sorry for misleading.
There was a problem hiding this comment.
Currently orchagent freeze by sleep, I will check if can improve the restart code in orchagent by stop handle all task:
SWSS_LOG_WARN("Orchagent is frozen for warm restart!");
sleep(UINT_MAX);
|
Close this PR, will fix the issue in Orchagent: sonic-net/sonic-swss#2923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix supervisor-proc-exit-listener false alert during warm reboot issue: #16686
Why I did it
supervisor-proc-exit-listener will generate false alert during warm reboot.
Work item tracking
How I did it
Ignore alert message during warm reboot.
How to verify it
Pass all UT.
Manually verify issue fixed:
Sep 28 07:53:20.285652 vlab-01 ERR swss#supervisor-proc-exit-listener: message repeated 27 times: [ Process 'orchagent' is stuck in namespace 'host' (7.0 minutes).]
Sep 28 07:53:20.287377 vlab-01 INFO swss#supervisor-proc-exit-listener: Warm rebooting, Process 'orchagent' is stuck in namespace 'host' (7.0 minutes).
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Fix supervisor-proc-exit-listener false alert during warm reboot issue.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)