Checking java download against a checksum for security #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbradicich
approved these changes
Dec 9, 2016
| @@ -25,19 +25,21 @@ ENV JAVA_HOME /opt/java | |||
| ENV JAVA_VERSION_MAJOR 8 | |||
| ENV JAVA_VERSION_MINOR 102 | |||
| ENV JAVA_VERSION_BUILD 14 | |||
|
|
|||
| ENV JAVA_CHECKSUM="50bc7ff61ba064c471adc2ec08e44690f0dac4cd673a3666b6d7b24a48bd7169" | |||
There was a problem hiding this comment.
might be worth adding a note here (in both files) linking to https://www.oracle.com/webfolder/s/digest/8u102checksum.html to show where this came from, and that its actually a legit value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Oracle's JRE is being downloaded over HTTP, but not checked against a secure checksum, I considered this a bit of a security issue. I added a variable for a sha256 checksum and checked against this after the download in the OSS and Pro dockerfiles.
Oracle supplies these checksums officially for this version at https://www.oracle.com/webfolder/s/digest/8u102checksum.html
Subsequent updates of the JRE version in these dockerfiles should update the checksum accordingly.
Feel free to give me feedback if the change should need more work. :)