Rector

src/Command/AddMassMediaCommand.php

@@ -57,7 +57,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $readHeaders = false;
 
         while (!feof($fp)) {
-            $data = fgetcsv($fp, 0, $delimiter, $enclosure, $escape);
+            $data = fgetcsv($fp, 0, $delimiter, $enclosure, (string) $escape);
 
             if (!\is_array($data)) {
                 continue;

src/Filesystem/Replicate.php

@@ -25,14 +25,11 @@
 
 final class Replicate implements Adapter, FileFactory, StreamFactory, MetadataSupporter
 {
-    private LoggerInterface $logger;
-
     public function __construct(
         private Adapter $primary,
         private Adapter $secondary,
-        ?LoggerInterface $logger = null,
+        private LoggerInterface $logger = new NullLogger()
     ) {
-        $this->logger = $logger ?? new NullLogger();
     }
 
     public function delete($key): bool

src/Metadata/AmazonMetadataBuilder.php

@@ -53,18 +53,15 @@ final class AmazonMetadataBuilder implements MetadataBuilderInterface
         'reduced' => self::STORAGE_REDUCED,
     ];
 
-    private MimeTypesInterface $mimeTypes;
-
     /**
      * @param array<string, mixed> $settings
      *
      * @phpstan-param AmazonSettings $settings
      */
     public function __construct(
         private array $settings,
-        ?MimeTypesInterface $mimeTypes = null,
+        private MimeTypesInterface $mimeTypes = new MimeTypes()
     ) {
-        $this->mimeTypes = $mimeTypes ?? new MimeTypes();
     }
 
     public function get(MediaInterface $media, string $filename): array

src/Model/NoDriverGalleryManager.php

@@ -95,16 +95,9 @@ public function getTableName(): string
     }
 
     /**
-     * Do not add return typehint to this method, it forces a dependency with
-     * Doctrine DBAL that we do not want here. This method will probably be
-     * deprecated on sonata-project/doctrine-extensions because it is only for
-     * Doctrine ORM.
-     *
      * TODO: Remove this with the drop of sonata-project/doctrine-extensions < 2.
-     *
-     * @psalm-suppress MissingReturnType
      */
-    public function getConnection() // @phpstan-ignore-line
+    public function getConnection(): never
     {
         throw new NoDriverException();
     }

src/Model/NoDriverMediaManager.php

@@ -95,16 +95,9 @@ public function getTableName(): string
     }
 
     /**
-     * Do not add return typehint to this method, it forces a dependency with
-     * Doctrine DBAL that we do not want here. This method will probably be
-     * deprecated on sonata-project/doctrine-extensions because it is only for
-     * Doctrine ORM.
-     *
      * TODO: Remove this with the drop of sonata-project/doctrine-extensions < 2.
-     *
-     * @psalm-suppress MissingReturnType
      */
-    public function getConnection() // @phpstan-ignore-line
+    public function getConnection(): never
     {
         throw new NoDriverException();
     }

src/Provider/DailyMotionProvider.php

@@ -150,7 +150,7 @@ private function fixBinaryContent(MediaInterface $media): void
             return;
         }
 
-        if (1 === preg_match('{^(?:https?://)?www.dailymotion.com/video/(?<video_id>[0-9a-zA-Z]*)}', $media->getBinaryContent(), $matches)) {
+        if (1 === preg_match('{^(?:https?://)?www.dailymotion.com/video/(?<video_id>[0-9a-zA-Z]*)}', (string) $media->getBinaryContent(), $matches)) {
             $media->setBinaryContent($matches['video_id']);
         }
     }

src/Provider/FileProvider.php

@@ -285,7 +285,7 @@ public function validate(ErrorElement $errorElement, MediaInterface $media): voi
 
         if (
             '' !== $media->getBinaryContent()->getFilename()
-            && !\in_array(strtolower($media->getBinaryContent()->getMimeType()), $this->allowedMimeTypes, true)
+            && !\in_array(strtolower((string) $media->getBinaryContent()->getMimeType()), $this->allowedMimeTypes, true)
         ) {
             $errorElement
                 ->with('binaryContent')

src/Provider/VimeoProvider.php

@@ -134,7 +134,7 @@ protected function fixBinaryContent(MediaInterface $media): void
             return;
         }
 
-        if (1 === preg_match('{vimeo\.com/(?:video/|)(?<video_id>\d+)}', $media->getBinaryContent(), $matches)) {
+        if (1 === preg_match('{vimeo\.com/(?:video/|)(?<video_id>\d+)}', (string) $media->getBinaryContent(), $matches)) {
             $media->setBinaryContent($matches['video_id']);
         }
     }

src/Provider/YouTubeProvider.php

@@ -255,13 +255,13 @@ private function fixBinaryContent(MediaInterface $media): void
             return;
         }
 
-        if (11 === \strlen($media->getBinaryContent())) {
+        if (11 === \strlen((string) $media->getBinaryContent())) {
             return;
         }
 
         if (1 === preg_match(
             '{^(?:https?://)?(?:www\.)?(?:m\.)?(?:youtu\.be/|youtube\.com/(?:(?:watch)?\?(?:.*&)?v(?:i)?=|(?:embed|v|vi|user)/))(?<video_id>[^\#\?&\'>]+)}',
-            $media->getBinaryContent(),
+            (string) $media->getBinaryContent(),
             $matches
         )) {
             $media->setBinaryContent($matches['video_id']);