Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][gcp] Improve the way of collection for DiskTypes and MachineTypes #2284

Merged

Conversation

1101-1
Copy link
Collaborator

@1101-1 1101-1 commented Nov 29, 2024

Description

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@1101-1 1101-1 changed the title [feat][gcp] Improve the way of collection for SKUs and Machine Types [feat][gcp] Improve the way of collection for DiskTypes and MachineTypes Nov 29, 2024
plugins/gcp/fix_plugin_gcp/resources/base.py Outdated Show resolved Hide resolved
plugins/gcp/fix_plugin_gcp/resources/base.py Outdated Show resolved Hide resolved
plugins/gcp/fix_plugin_gcp/resources/base.py Show resolved Hide resolved
plugins/gcp/fix_plugin_gcp/resources/base.py Show resolved Hide resolved
@1101-1 1101-1 force-pushed the km/gcp_improve_collection_of_gcp_sku_and_machine_types branch from 95a6a11 to c5eecb2 Compare December 4, 2024 09:14
@aquamatthias aquamatthias merged commit 54024e5 into main Dec 4, 2024
6 checks passed
@aquamatthias aquamatthias deleted the km/gcp_improve_collection_of_gcp_sku_and_machine_types branch December 4, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants