Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcp][feat] Add metrics collection #2283

Merged
merged 45 commits into from
Dec 4, 2024
Merged

Conversation

1101-1
Copy link
Collaborator

@1101-1 1101-1 commented Nov 20, 2024

Description

Services where metrics collection has completed:

  • Instance
  • Volume
  • Database
  • Load Balancers
  • Serverless

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@1101-1 1101-1 marked this pull request as draft November 20, 2024 17:36
plugins/gcp/fix_plugin_gcp/collector.py Outdated Show resolved Hide resolved
plugins/gcp/fix_plugin_gcp/collector.py Outdated Show resolved Hide resolved
plugins/gcp/fix_plugin_gcp/resources/base.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias previously approved these changes Nov 27, 2024
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@1101-1 1101-1 marked this pull request as ready for review November 28, 2024 15:18
aquamatthias
aquamatthias previously approved these changes Nov 28, 2024
aquamatthias
aquamatthias previously approved these changes Dec 2, 2024
@aquamatthias aquamatthias merged commit c626700 into main Dec 4, 2024
23 checks passed
@aquamatthias aquamatthias deleted the km/gcp_collect_metrics branch December 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants