Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcp][feat] Add filestore service collection #2277

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

1101-1
Copy link
Collaborator

@1101-1 1101-1 commented Nov 9, 2024

Description

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can we add a test case?

@1101-1 1101-1 force-pushed the km/gcp_filestore_collection branch from a1c5c0f to 2ebe747 Compare November 11, 2024 14:38
@aquamatthias aquamatthias merged commit 6a68104 into main Nov 11, 2024
6 checks passed
@aquamatthias aquamatthias deleted the km/gcp_filestore_collection branch November 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants