Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access Edges #2195

Merged
merged 55 commits into from
Oct 8, 2024
Merged

Access Edges #2195

merged 55 commits into from
Oct 8, 2024

Conversation

meln1k
Copy link
Member

@meln1k meln1k commented Sep 16, 2024

Description

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

aquamatthias
aquamatthias reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. Added a couple of comments.

plugins/aws/fix_plugin_aws/resource/base.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/base.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/base.py Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/s3.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/collector.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Outdated Show resolved Hide resolved
@meln1k meln1k changed the title Access Edges draft pr Access Edges Sep 23, 2024
@meln1k meln1k marked this pull request as ready for review September 23, 2024 17:54
@meln1k meln1k requested a review from lloesche as a code owner September 23, 2024 17:54
aquamatthias
aquamatthias reviewed Sep 24, 2024
View reviewed changes
plugins/aws/fix_plugin_aws/access_edges_utils.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/collector.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/base.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
We cover all resource kinds that define policies on resource level - not only s3.
Can you add them?

fixlib/fixlib/baseresources.py Outdated Show resolved Hide resolved
fixlib/fixlib/graph/__init__.py Outdated Show resolved Hide resolved
fixlib/fixlib/graph/__init__.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/configuration.py Show resolved Hide resolved
plugins/aws/fix_plugin_aws/access_edges.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meln1k
Copy link
Member Author

meln1k commented Oct 1, 2024

will add more principals and we're ready go merge this

aquamatthias
aquamatthias reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits before we can merge this

plugins/aws/fix_plugin_aws/configuration.py Outdated Show resolved Hide resolved
fixlib/fixlib/baseresources.py Outdated Show resolved Hide resolved
fixlib/fixlib/baseresources.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias reviewed Oct 8, 2024
View reviewed changes
plugins/aws/fix_plugin_aws/resource/backup.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/dynamodb.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/dynamodb.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/ecr.py Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/efs.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/kms.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/lambda_.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/secretsmanager.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/sns.py Outdated Show resolved Hide resolved
plugins/aws/fix_plugin_aws/resource/sqs.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meln1k meln1k merged commit c6e9b82 into main Oct 8, 2024
25 checks passed
@meln1k meln1k deleted the nm/access-edge-creator-process branch October 8, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@lloesche lloesche Awaiting requested review from lloesche lloesche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meln1k @aquamatthias