Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure][feat]: Update configs collection for mysql and postgresql #2157

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

1101-1
Copy link
Collaborator

@1101-1 1101-1 commented Jul 31, 2024

Description

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@1101-1 1101-1 marked this pull request as draft July 31, 2024 15:30
@1101-1 1101-1 force-pushed the azure_psql_mysql_configs branch from c7007b4 to c15925a Compare August 2, 2024 12:58
@1101-1 1101-1 force-pushed the azure_psql_mysql_configs branch from 1165a9c to ac8aed2 Compare August 2, 2024 13:04
@1101-1 1101-1 marked this pull request as ready for review August 2, 2024 13:11
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please find my comments.

plugins/azure/fix_plugin_azure/resource/mysql.py Outdated Show resolved Hide resolved
plugins/azure/fix_plugin_azure/utils.py Outdated Show resolved Hide resolved
plugins/azure/fix_plugin_azure/utils.py Show resolved Hide resolved
plugins/azure/fix_plugin_azure/utils.py Show resolved Hide resolved
plugins/azure/fix_plugin_azure/resource/mysql.py Outdated Show resolved Hide resolved
@aquamatthias aquamatthias merged commit f692309 into someengineering:main Aug 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants