Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][chore] Rename Resoto -> Fix #1943

Merged
merged 23 commits into from
Feb 27, 2024
Merged

[fix][chore] Rename Resoto -> Fix #1943

merged 23 commits into from
Feb 27, 2024

Conversation

aquamatthias
Copy link
Member

Description

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 97.82110% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 89.94%. Comparing base (8e306a1) to head (05c4a36).

Files Patch % Lines
fixcore/fixcore/config/core_config_handler.py 88.63% 5 Missing ⚠️
fixcore/fixcore/__main__.py 95.23% 2 Missing ⚠️
fixcore/fixcore/cli/command.py 96.55% 2 Missing ⚠️
fixcore/fixcore/web/api.py 96.72% 2 Missing ⚠️
fixcore/fixcore/web/tsdb.py 50.00% 2 Missing ⚠️
fixcore/fixcore/cli/cli.py 94.44% 1 Missing ⚠️
fixcore/fixcore/cli/model.py 92.30% 1 Missing ⚠️
fixcore/fixcore/core_config.py 97.95% 1 Missing ⚠️
fixcore/fixcore/report/inspector_service.py 96.42% 1 Missing ⚠️
fixcore/fixcore/system_start.py 95.23% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1943   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files          94       94           
  Lines       16684    16684           
=======================================
  Hits        15006    15006           
  Misses       1678     1678           
Flag Coverage Δ
fixcore 89.94% <97.82%> (?)
resotocore ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aquamatthias aquamatthias marked this pull request as ready for review February 26, 2024 21:35
lloesche
lloesche previously approved these changes Feb 26, 2024
@aquamatthias aquamatthias merged commit 2393592 into main Feb 27, 2024
28 checks passed
@aquamatthias aquamatthias deleted the mv/rename branch February 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants